[webkit-reviews] review granted: [Bug 81175] [chromium] Add overdraw metrics for texture uploads : [Attachment 132061] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 15 17:11:52 PDT 2012
Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 81175: [chromium] Add overdraw metrics for texture uploads
https://bugs.webkit.org/show_bug.cgi?id=81175
Attachment 132061: Patch
https://bugs.webkit.org/attachment.cgi?id=132061&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132061&action=review
Looks good. R=me.
> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:66
> + bool isDirtyForCurrentFrame() { return !m_dirtyRect.isEmpty() &&
(m_updateRect.isEmpty() || m_updateCulled); }
nit: can you add a comment to explain this expression?
More information about the webkit-reviews
mailing list