[webkit-reviews] review requested: [Bug 76686] HistoryItem not updated properly when a form submission begins before a previous form submission has finished : [Attachment 132143] v1 patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 15 16:30:01 PDT 2012
Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked for review:
Bug 76686: HistoryItem not updated properly when a form submission begins
before a previous form submission has finished
https://bugs.webkit.org/show_bug.cgi?id=76686
Attachment 132143: v1 patch
https://bugs.webkit.org/attachment.cgi?id=132143&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Here's a very simple patch that corrects the bug. This copies logic from
the end of FrameLoader::loadURL(). I'm not super keen on just copying that
code, but at least it is a small amount of code. I considered moving this
code into loadWithNavigationAction, but I couldn't convince myself that it
was correct to run it in all cases as loadWithNavigationAction gets called
elsewhere under different conditions.
I've included a layout test for the case that passed before my change,
namely that of using GET instead of POST.
More information about the webkit-reviews
mailing list