[webkit-reviews] review granted: [Bug 76746] [Chromium] IndexedDB: Assertion failure when storing File objects : [Attachment 132110] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 76746: [Chromium] IndexedDB: Assertion failure when storing File objects
https://bugs.webkit.org/show_bug.cgi?id=76746

Attachment 132110: Patch
https://bugs.webkit.org/attachment.cgi?id=132110&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132110&action=review


> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:1000
> +	   uint32_t length = fileList->length();
> +	   for (unsigned i = 0; i < length; ++i)

Nit: It looks like the return type is 'unsigned' for FileList::length().

> LayoutTests/storage/indexeddb/noblobs.html:9
> +<div id="console"></div>

Nit: I think js-test-pre.js will auto create the console div for you.