[webkit-reviews] review granted: [Bug 78027] CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail : [Attachment 132119] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 78027: CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015
fail
https://bugs.webkit.org/show_bug.cgi?id=78027

Attachment 132119: Patch
https://bugs.webkit.org/attachment.cgi?id=132119&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132119&action=review


> Source/WebCore/rendering/FixedTableLayout.cpp:105
> +    for (;child && child->isTableCol(); child = nextCol(child)) {

The initialization ("RenderObject* child = m_table->firstChild();") should be
moved here too. Also space after ';' please.

> Source/WebCore/rendering/FixedTableLayout.cpp:143
>	   col->computePreferredLogicalWidths();

AFAICT this doesn't depend on any of the computation we are doing here so it
could just be hoisted before your |if| (around line 109) to avoid another
breakage down the line.