[webkit-reviews] review granted: [Bug 80875] GestureTapDown needs to pin in-progress flings : [Attachment 131392] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 80875: GestureTapDown needs to pin in-progress flings
https://bugs.webkit.org/show_bug.cgi?id=80875

Attachment 131392: Patch
https://bugs.webkit.org/attachment.cgi?id=131392&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131392&action=review


This looks fine.  I'm always torn for these patch in how hard I should push you
for tests.  It seems like we don't have much test coverage for this code, which
makes me worry that we'll break it in the future.

> Source/WebCore/page/EventHandler.cpp:2371
> +    FrameView* view = m_frame->view();
> +    if (view) {

Prefer early return.

> Source/WebCore/page/EventHandler.cpp:2375
> +	      return false;

Bad indent.