[webkit-reviews] review granted: [Bug 81222] [chromium] Changes to overdraw metrics to allow upload tracking : [Attachment 132054] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 15 13:23:43 PDT 2012
Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 81222: [chromium] Changes to overdraw metrics to allow upload tracking
https://bugs.webkit.org/show_bug.cgi?id=81222
Attachment 132054: Patch
https://bugs.webkit.org/attachment.cgi?id=132054&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132054&action=review
R=me. It makes sense to rename painting to upload, since we may paint much
more if we're not using per-tile painting.
> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:113
> + OwnPtr<CCOverdrawMetrics> m_overdrawMetrics;
nit: Maybe make this a local, since you always create it and return a reference
to it?
More information about the webkit-reviews
mailing list