[webkit-reviews] review granted: [Bug 80487] Move NotificationContents into Notification : [Attachment 131186] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 80487: Move NotificationContents into Notification
https://bugs.webkit.org/show_bug.cgi?id=80487

Attachment 131186: Patch
https://bugs.webkit.org/attachment.cgi?id=131186&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131186&action=review


> Source/WebCore/notifications/Notification.h:77
> +    KURL iconURL() { return m_icon; }

Please add const modifier.

> Source/WebCore/notifications/Notification.h:79
> +    void setTitle(const String& title) { m_title = title; }

It seems that none is accessing setTitle and setBody now. Will they be used in
the future patch?