[webkit-reviews] review granted: [Bug 81117] [GTK] Implement unicode submenu items : [Attachment 132003] Updated patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 81117: [GTK] Implement unicode submenu items
https://bugs.webkit.org/show_bug.cgi?id=81117

Attachment 132003: Updated patch
https://bugs.webkit.org/attachment.cgi?id=132003&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132003&action=review


> Source/WebCore/page/ContextMenuController.cpp:192
> +static void insertUnicodeCharacter(UChar uchar, Frame* frame)
> +{
> +    String text(&uchar, 1);

You should probably just call this UChar char or UChar character. Converting
UChar to camel-case leaves uChar.