[webkit-reviews] review granted: [Bug 81219] Enable animVal support for SVGNumberList : [Attachment 132045] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 07:56:37 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 81219: Enable animVal support for SVGNumberList
https://bugs.webkit.org/show_bug.cgi?id=81219

Attachment 132045: Patch
https://bugs.webkit.org/attachment.cgi?id=132045&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132045&action=review


LGTM.

> Source/WebCore/svg/SVGAnimatedNumberList.h:49
> +    virtual PassOwnPtr<SVGAnimatedType>
constructFromCopy(SVGGenericAnimatedType*);

As discussed on irc, constructFromVariant may be a better name.


More information about the webkit-reviews mailing list