[webkit-reviews] review granted: [Bug 81212] Enable animVal support for SVGNumber : [Attachment 132028] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 07:09:04 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 81212: Enable animVal support for SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=81212

Attachment 132028: Patch
https://bugs.webkit.org/attachment.cgi?id=132028&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132028&action=review


LGTM.

> Source/WebCore/svg/properties/SVGAnimatedStaticPropertyTearOff.h:2
> + * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.

I think we always use 2010, 2011, 2012 style in our own files, maybe check. If
we already break this style in our SVG contributions then this patch should not
be the one fixing that, but we should discuss making a patch to use one style
in future.


More information about the webkit-reviews mailing list