[webkit-reviews] review granted: [Bug 81088] Web Inspector: extract CompilerScriptMapping from RawSourceCode. : [Attachment 131869] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 81088: Web Inspector: extract CompilerScriptMapping from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=81088

Attachment 131869: Patch
https://bugs.webkit.org/attachment.cgi?id=131869&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131869&action=review


> Source/WebCore/inspector/front-end/CompilerScriptMapping.js:1
> +/*

Could you please add new file to compilation.

> Source/WebCore/inspector/front-end/CompilerScriptMapping.js:137
> +	   for (var url in this._uiSourceCodeByURL) {

This loop does not make sense, you probably meant to dispatch the event once.