[webkit-reviews] review granted: [Bug 80758] Enable animVal support for SVGTransformList : [Attachment 132016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 04:26:22 PDT 2012


Antti Koivisto <koivisto at iki.fi> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 80758: Enable animVal support for SVGTransformList
https://bugs.webkit.org/show_bug.cgi?id=80758

Attachment 132016: Patch
https://bugs.webkit.org/attachment.cgi?id=132016&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=132016&action=review


r=me

> Source/WebCore/svg/SVGAnimatedTransformList.cpp:3
> +/*
> + * Copyright (C) Research In Motion Limited 2012. All rights reserved.
> + *

You might want to preserve the copyright as this code is at least based on the
original code.

> Source/WebCore/svg/SVGAnimatedTransformList.cpp:92
> +    // ‘to’ attribute value, which conflicts mathematically with the
requirement for additive transform animations

Strange characters around 'to', but maybe it is just bugzilla?


More information about the webkit-reviews mailing list