[webkit-reviews] review granted: [Bug 81144] [Qt][WK2] Fix bounce-back behaviour for panning : [Attachment 131904] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 02:48:30 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 81144: [Qt][WK2] Fix bounce-back behaviour for panning
https://bugs.webkit.org/show_bug.cgi?id=81144

Attachment 131904: proposed patch
https://bugs.webkit.org/attachment.cgi?id=131904&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131904&action=review


> Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp:70
>	   interactionEngine()->panGestureCancelled();
> +	  
interactionEngine()->ensureContentWithinViewportBoundary(/*immediate*/ true);
>	   return false;

hmm, yes you move it back immediately, but isn't the other animation still
running?


More information about the webkit-reviews mailing list