[webkit-reviews] review canceled: [Bug 72852] Scroll position is lost after hide/show element : [Attachment 120026] Updated patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Rakesh
<rakesh.kn at motorola.com>'s request for review:
Bug 72852: Scroll position is lost after hide/show element
https://bugs.webkit.org/show_bug.cgi?id=72852

Attachment 120026: Updated patch
https://bugs.webkit.org/attachment.cgi?id=120026&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120026&action=review


Unfortunately Darin didn't comment on the latest patch and it fell off my
radar. The patch has unfortunately rotten and would need to be rebaselined on
ToT.

> Source/WebCore/ChangeLog:12
> +	   Resetting the saved scroll offset if node is moved to other location
in same document or other document.

Darin asked about that in his latest review. Does it match the other browsers
here?

> Source/WebCore/rendering/RenderLayer.cpp:199
> +	   // We save and restore only the scrollOffset as the other scroll
values are recalulated.

recalculated