[webkit-reviews] review granted: [Bug 80900] (register|unregister)DynamicSubtreeNodeList should be called only for labels and regions node lists : [Attachment 131777] Updated for ToT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 14 20:35:29 PDT 2012


Andreas Kling <kling at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 80900: (register|unregister)DynamicSubtreeNodeList should be called only
for labels and regions node lists
https://bugs.webkit.org/show_bug.cgi?id=80900

Attachment 131777: Updated for ToT
https://bugs.webkit.org/attachment.cgi?id=131777&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131777&action=review


r=me but please remove references to region node lists from the code/changelog.


Bonus points for removing a parseAttribute() overload. :)

> Source/WebCore/dom/DynamicNodeList.h:90
> +    DynamicNodeList::invalidateCache;

Needs "using" to build on win, but you know that.


More information about the webkit-reviews mailing list