[webkit-reviews] review requested: [Bug 78856] visual word movement: Using ICU break iterator to simplify implementation : [Attachment 131956] patch w/ layout test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 14 16:43:27 PDT 2012
Xiaomei Ji <xji at chromium.org> has asked for review:
Bug 78856: visual word movement: Using ICU break iterator to simplify
implementation
https://bugs.webkit.org/show_bug.cgi?id=78856
Attachment 131956: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=131956&action=review
------- Additional Comments from Xiaomei Ji <xji at chromium.org>
I did not consolidate previousRootInlineBox with the functionality in
previousLinePosition. There are a couple of differences there (for example, the
RenderPosition and ShadowNode), and I am hesitate to change
previousLinePosition() in this patch to make it more inline with
previousRootInlineBox. And consolidate to a single function with parameters to
control different requirement looks not nice.
More information about the webkit-reviews
mailing list