[webkit-reviews] review granted: [Bug 80922] Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS : [Attachment 131795] Same patch again, to go through mac ews

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 80922: Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
https://bugs.webkit.org/show_bug.cgi?id=80922

Attachment 131795: Same patch again, to go through mac ews
https://bugs.webkit.org/attachment.cgi?id=131795&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131795&action=review


> Source/WebCore/bindings/scripts/InFilesCompiler.pm:174
> +    my @conditionals = split('\\|', $conditional);

It seems that we only handle '|', not '&' here. But since handling of '&' is
not required for this patch, you should consider it in another patch or ask
Adam to enhance it.

> Source/WebCore/bindings/scripts/InFilesCompiler.pm:224
> +

Remove empty line.