[webkit-reviews] review granted: [Bug 81101] sheriffbot should also be addressable with a comma in addition to colon : [Attachment 131941] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 81101: sheriffbot should also be addressable with a comma in addition to
colon
https://bugs.webkit.org/show_bug.cgi?id=81101

Attachment 131941: Patch
https://bugs.webkit.org/attachment.cgi?id=131941&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131941&action=review


> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:86
> +	   # Some IRC clients, like xchat-gnome, default to using a comma
> +	   # when addressing someone.
> +	   try:
> +	       vocative_separator = request[len(connection.get_nickname())]
> +	   except IndexError:
> +	       return

This patch is fine, but you don't really need to use a try-catch block here.  A
simple length test should work fine.  :)