[webkit-reviews] review requested: [Bug 80323] [CSS Filters] Drop Shadow is not repainting correctly when repaint area is smaller than the filtered element : [Attachment 131921] Patch V1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 14 14:19:15 PDT 2012


Chiculita Alexandru <achicu at adobe.com> has asked  for review:
Bug 80323: [CSS Filters] Drop Shadow is not repainting correctly when repaint
area is smaller than the filtered element
https://bugs.webkit.org/show_bug.cgi?id=80323

Attachment 131921: Patch V1
https://bugs.webkit.org/attachment.cgi?id=131921&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
The patch may seem to fix multiple bugs, but they are only a consequence of the
fact that now I made the filtered layers act as repaint container. That is
similar to how composited layers work. Using that we can intercept all the
repaints in a single place.

Also in order to make those repaints useful (and testable) I needed to fix the
filter painting to keep a full source image of the original RenderLayer, so
that drop shadow and blur can apply correctly.


More information about the webkit-reviews mailing list