[webkit-reviews] review denied: [Bug 80705] Simplify memory usage tracking in CopiedSpace : [Attachment 131362] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 80705: Simplify memory usage tracking in CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=80705

Attachment 131362: Patch
https://bugs.webkit.org/attachment.cgi?id=131362&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
A few notes here:

- Please change Heap::size() and Heap::capacity() to include CopiedSpace, and
remove code that manually adds in CopiedSpace.

- I don't think we want an explicit CopiedSpace::calculateWaterMark(). Rather,
any allocation should automatically add to the watermark, and the start of GC
should clear the watermark. In cases where that's inefficient, you should defer
adding to the watermark until the allocate slow case. You can copy the design
of MarkedSpace here.

- You should add capacity() to the watermark, not size().