[webkit-reviews] review denied: [Bug 72841] NRWT: option --skip-pixel-test-if-no-baseline support on DRT : [Attachment 131828] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Nandor Huszka
<hnandor at inf.u-szeged.hu>'s request for review:
Bug 72841: NRWT: option --skip-pixel-test-if-no-baseline support on DRT
https://bugs.webkit.org/show_bug.cgi?id=72841

Attachment 131828: Patch
https://bugs.webkit.org/attachment.cgi?id=131828&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131828&action=review


Almost there. Make sure that test-webkitpy passes after this next iteration and
you should be all set.

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:97
> +	       self._driver._pixel_tests = False

instead of modifying self._driver._pixel_tests here (which should be a private
member of driver), just modify the driver implementations and delete the
_pixel_tests member from them.

> Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:213
> +	   if test_input.run_pixel_test:

This won't actually work. This code needs to know if something is actually a
reftest. You will need to modify the run(), input_from_line(), and
output_for_test() methods to pass around is_reftest as a separate argument.

> Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:276
> +	   if self._options.pixel_tests and (test_input.image_hash or
test_input.run_pixel_test):

See above. This needs to stay as is_reftest, as a separate argument.

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:482
> +	   if pixel_tests and self._pixel_tests:

Just remove the reference to self._pixel_tests completely.