[webkit-reviews] review granted: [Bug 78882] [CSSRegions][CSSOM] Implement regionLayoutEvent : [Attachment 131355] Added simple check for any existing listeners

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 14 10:43:28 PDT 2012


Dave Hyatt <hyatt at apple.com> has granted Raul Hudea <rhudea at adobe.com>'s
request for review:
Bug 78882: [CSSRegions][CSSOM] Implement regionLayoutEvent
https://bugs.webkit.org/show_bug.cgi?id=78882

Attachment 131355: Added simple check for any existing listeners
https://bugs.webkit.org/attachment.cgi?id=131355&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131355&action=review


I still disagree with the idea of firing on every region, but I guess we can
argue about that on the list. Especially once we have regions that have no
elements, I don't think it will make sense to try to make them the target of
events.

Anyway, r=me.

> Source/WebCore/dom/Node.cpp:2782
> +    if (!document()->hasListenerType(Document::REGIONLAYOUTUPDATE_LISTENER))

> +	   return;

Yup, great, that's all I was looking for here.


More information about the webkit-reviews mailing list