[webkit-reviews] review denied: [Bug 80602] Convert some fast/regions pixel tests to reftests : [Attachment 131373] re-uploading the patch to re-run gtk EWS

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied hermwong <hermanw at adobe.com>'s
request for review:
Bug 80602: Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=80602

Attachment 131373: re-uploading the patch to re-run gtk EWS
https://bugs.webkit.org/attachment.cgi?id=131373&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131373&action=review


> LayoutTests/ChangeLog:8
> +	   Convert some fast/regions pixel tests to reftests
> +	   https://bugs.webkit.org/show_bug.cgi?id=80602
> +
> +	   Reviewed by NOBODY (OOPS!).

Please add a more detailed description what you changed. Also, you changed some
test files, these need comments as well. You can put the comments directly next
to/under the file names in the ChangeLog.

>
LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html:4
5
> +is contained in. It should fill the left half of the first region.</p>

Should you see red on the page? If so it is a bad tests :) Why did you remove
the comment?

>
LayoutTests/fast/regions/positioned-objects-inline-static-spanning-regions.html
:-55
> -	       Some text.<br>
> -		Some text.<br>
> -		 Some text.<br>
> -		  Some text.<br>
> -		   Some text.<br> Some text.<br> Some text.<br> Some text.<br>
Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some
text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some
text.<br>      </span>

Why did you remove the text and the break lines?