[webkit-reviews] review requested: [Bug 80744] [chromium] Threaded opacity animation jump to opacity of 0 : [Attachment 131843] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 14 07:40:37 PDT 2012


vollick at chromium.org has asked	for review:
Bug 80744: [chromium] Threaded opacity animation jump to opacity of 0
https://bugs.webkit.org/show_bug.cgi?id=80744

Attachment 131843: Patch
https://bugs.webkit.org/attachment.cgi?id=131843&action=review

------- Additional Comments from vollick at chromium.org
There's no more copying back to the LayerChromiums. This patch just ensures we
don't skip subtrees due to opacity when opacity is animating.

I have also removed the code that bails when animation delay is set, since we
get that for free. I have also updated
CCLayerAnimationController::removeCompletedAnimations so that it does not
attempt to destroy animations on the wrong thread.

I will be writing another patch which will tick animations on the main thread
as well to supply better information to the culler, but this is a larger
change.


More information about the webkit-reviews mailing list