[webkit-reviews] review denied: [Bug 80380] [Forms] The "meter" element should not be a form-associated element. : [Attachment 131805] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 80380: [Forms] The "meter" element should not be a form-associated element.
https://bugs.webkit.org/show_bug.cgi?id=80380

Attachment 131805: Patch 2
https://bugs.webkit.org/attachment.cgi?id=131805&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131805&action=review


> Source/WebCore/html/LabelableElement.h:50
> +    virtual bool isLabelable() const OVERRIDE { return true; }

This should be "isLabelable() const OVERRIDE FINAL { return true; }" because
subclasses must not override this.

> LayoutTests/ChangeLog:14
> +	   * fast/dom/HTMLMeterElement/meter-element-form-expected.txt:
Removed.
> +	   * fast/dom/HTMLMeterElement/meter-element-form.html: Removed.

Please do not remove the test.	We should change it so that it confirms
HTMLMeterElement doesn't support "form" IDL attribute.