[webkit-reviews] review denied: [Bug 80380] [Forms] The "meter" element should not be a form-associated element. : [Attachment 131778] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 80380: [Forms] The "meter" element should not be a form-associated element.
https://bugs.webkit.org/show_bug.cgi?id=80380

Attachment 131778: Patch 1
https://bugs.webkit.org/attachment.cgi?id=131778&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131778&action=review


> Source/WebCore/html/HTMLElement.h:105
> +    virtual bool isLabelable() const { return false; }

The function means:
 * This HTMLElement can be casted to LabelableElement, AND
 * This LabelableElement actually supports "labels" property.

isClassName() functions of HTMLElement and Element usually have only the first
role. isLabelable() in this patch will make other developers confused.

I recommend to rename the existing LabelableElement::isLabelable() to
LabelableElement::supportLabels(), and restrict the role of
HTMLElement::isLabelable().