[webkit-reviews] review denied: [Bug 81056] Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:] : [Attachment 131756] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Jer Noble <jer.noble at apple.com>'s request for
review:
Bug 81056: Lion Intel Debug WebKit2 Tests crashing under
[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
https://bugs.webkit.org/show_bug.cgi?id=81056

Attachment 131756: Patch
https://bugs.webkit.org/attachment.cgi?id=131756&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=131756&action=review


> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:322
> +
> +    // Version 1:
> +    WKBundlePageBeganEnterFullScreen 				  
beganEnterFullScreen;
> +    WKBundlePageBeganExitFullScreen					  
beganExitFullScreen;
>  };
>  typedef struct WKBundlePageFullScreenClient WKBundlePageFullScreenClient;
>  
> -enum { kWKBundlePageFullScreenClientCurrentVersion = 0 };
> +enum { kWKBundlePageFullScreenClientCurrentVersion = 1 };

You need to add an APIClientTraits specialization for
WKBundlePageFullScreenClient now, so that the struct is properly zeroed out for
version 0 clients.