[webkit-reviews] review granted: [Bug 12499] External <use> xlink:href references do not work : [Attachment 131655] Proposed second part

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Renata Hodovan
<reni at webkit.org>'s request for review:
Bug 12499: External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Attachment 131655: Proposed second part
https://bugs.webkit.org/attachment.cgi?id=131655&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131655&action=review


Excellent work Reni! Thanks for your patience, it took a while :-) r=me with
some last comments. There are some "new mode 100755" changes to
page/ContentSecurityPolicy.h and platform/network/chromium/ResourceRequest.h
that should be avoided.

> LayoutTests/svg/custom/use-referencing-itself-expected.svg:4
> +  xmlns:xlink="http://www.w3.org/1999/xlink"
xmlns:xe="http://www.w3.org/2001/xml-events">

version/baseProfile/xm:id/width/height/xmlns:xinkxmns:xe are useless.