[webkit-reviews] review granted: [Bug 80471] [chromium] wrong transform causing incorrect culling : [Attachment 131699] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 13:17:17 PDT 2012


James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 80471: [chromium] wrong transform causing incorrect culling
https://bugs.webkit.org/show_bug.cgi?id=80471

Attachment 131699: Patch
https://bugs.webkit.org/attachment.cgi?id=131699&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131699&action=review


R=me. I like the forward decl idea as well.

> Source/WebKit/chromium/tests/CCRenderSurfaceTest.cpp:105
> +    // for reference, remove before committing
> +    // return CCSharedQuadState::create(originTransform(), drawTransform(),
contentRect(), clipRect(), drawOpacity(), isOpaque);

don't forget to do this


More information about the webkit-reviews mailing list