[webkit-reviews] review granted: [Bug 69531] animation-iteration-count does not handle floating point values correctly. : [Attachment 130948] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 69531: animation-iteration-count does not handle floating point values
correctly.
https://bugs.webkit.org/show_bug.cgi?id=69531

Attachment 130948: Patch
https://bugs.webkit.org/attachment.cgi?id=130948&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130948&action=review


I think Alexis asked for a link to the spec in the ChangeLog. Sorry that you
inherited the bad {} style from existing tests (probably my fault).

> LayoutTests/animations/fill-mode-iteration-count-non-integer.html:86
> +	       if (Math.abs(expectedValue - realValue) < allowance) {
> +		 result += "PASS";
> +	       } else {
> +		 result += "FAIL";
> +	       }

Single lines - no {}

> LayoutTests/animations/fill-mode-iteration-count-non-integer.html:104
> +	       if (Math.abs(expectedValue - realValue) < allowance) {
> +		 result += "PASS";
> +	       } else {
> +		 result += "FAIL";
> +	       }

Single lines - no {}