[webkit-reviews] review granted: [Bug 80886] Convert nodesFromRect tests to use Internals interface : [Attachment 131657] patch v3 (win buildfixes - more symbols exported)

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 80886: Convert nodesFromRect tests to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=80886

Attachment 131657: patch v3 (win buildfixes - more symbols exported)
https://bugs.webkit.org/attachment.cgi?id=131657&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131657&action=review


> Source/WebCore/testing/Internals.cpp:686
> +						 unsigned topPadding, unsigned
rightPadding, unsigned bottomPadding, unsigned leftPadding,

Nit: wrong indentation. We don't align arguments like this.

> Source/WebCore/testing/Internals.h:127
> +    PassRefPtr<NodeList> nodesFromRect(Document*, int /*x*/, int /*y*/,

We don't put variable names in comments

> Source/WebCore/testing/Internals.h:128
> +					  unsigned /*topPadding*/, unsigned
/*rightPadding*/, unsigned /*bottomPadding*/, unsigned /*leftPadding*/,

Ditto about the indentation

> Source/WebCore/testing/Internals.idl:102
> +	   NodeList nodesFromRect(in Document document, in long x, in long y,

Ditto about the indentation