[webkit-reviews] review granted: [Bug 80917] Refactor some code that is used to check whether a layer needs backing store : [Attachment 131478] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 10:42:43 PDT 2012


Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 80917: Refactor some code that is used to check whether a layer needs
backing store
https://bugs.webkit.org/show_bug.cgi?id=80917

Attachment 131478: Patch
https://bugs.webkit.org/attachment.cgi?id=131478&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131478&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:-836
> -
> -    // If we have got this far and the renderer has no children, then we're
ok.
> -    if (!renderObject->firstChild())
> -	   return true;

It seems like this is no longer tested for an early return?


More information about the webkit-reviews mailing list