[webkit-reviews] review granted: [Bug 81009] 3D transformed surfaces with z>0 gets cropped : [Attachment 131662] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Lars Knudsen
<lars.knudsen at nokia.com>'s request for review:
Bug 81009: 3D transformed surfaces with z>0 gets cropped
https://bugs.webkit.org/show_bug.cgi?id=81009

Attachment 131662: Patch
https://bugs.webkit.org/attachment.cgi?id=131662&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131662&action=review


LGTM - see nitpicks

> Source/WebCore/ChangeLog:11
> +	   The scissor clipping in TextureMapperGL didn't
> +	   take 3D transforms into account when calculating
> +	   the clipping region.  Now, it will bail out early
> +	   if the transform is not affine.

Weird line wrapping :)

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:607
> +    if (!modelViewMatrix.isAffine())

Add a comment