[webkit-reviews] review canceled: [Bug 43022] 100% height elements to not respond to vertical browser rescaling : [Attachment 131459] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 09:08:26 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has canceled Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 43022: 100% height elements to not respond to vertical browser rescaling
https://bugs.webkit.org/show_bug.cgi?id=43022

Attachment 131459: Patch
https://bugs.webkit.org/attachment.cgi?id=131459&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131459&action=review


> LayoutTests/ChangeLog:14
> +	   *
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected
.png: Removed.
> +	   *
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.p
ng:

This rebaseline is wrong. Look at the scrollbars!

I should have been clearer: we may share the text baseline but may not share
the image baselines due to platform difference in painting native controls. In
this case, the text baseline is the same, the image needs to regenerated on
Chromium Win.

> LayoutTests/ChangeLog:16
> +	   *
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.t
xt:
> +		 Rebaseline for chromium.

Have you investigated why this test has a difference? I don't see any
explanation as to why we are fine with updating the baselines and I would like
one.

> LayoutTests/ChangeLog:22
> +	   * platform/efl/Skipped:
> +	   * platform/gtk/Skipped:
> +	   * platform/mac/Skipped:
> +	   * platform/qt/Skipped:
> +	   * platform/win/Skipped:
> +		 Skip the rebaselined test on all platforms except for
chromium. 

You should skip it on Chromium too because it will fail:
* IMAGE+TEXT on Mac
* IMAGE on Windows


More information about the webkit-reviews mailing list