[webkit-reviews] review granted: [Bug 80856] Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent : [Attachment 131455] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 80856: Split the extra logic out of
RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856

Attachment 131455: Patch
https://bugs.webkit.org/attachment.cgi?id=131455&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131455&action=review


> Source/WebCore/ChangeLog:3
> +	   Split the extra logic out of
RenderObjectChildList::updateBeforeAfterContent

Btw, I don't know what the "extra logic" is. I guess it should be either
* Split some logic out of RenderObjectChildList::updateBeforeAfterContent
* Extra part of the generated content handling logic out of
RenderObjectChildList::updateBeforeAfterContent

> Source/WebCore/ChangeLog:12
> +	   (WebCore):

Useless line (not your fault as prepare-ChangeLog has been sick for some time).


> Source/WebCore/ChangeLog:14
> +	   (WebCore::createBeforeAfterGeneratedContentContainer):

Stale entry.

> Source/WebCore/rendering/RenderObjectChildList.cpp:350
> +    if (child && child->style()->styleType() == type) {

Nit: This could use an early return.