[webkit-reviews] review denied: [Bug 80974] Dromaeo perf-tests results are wrong : [Attachment 131576] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 02:42:53 PDT 2012


Hajime Morrita <morrita at google.com> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 80974: Dromaeo perf-tests results are wrong
https://bugs.webkit.org/show_bug.cgi?id=80974

Attachment 131576: Patch
https://bugs.webkit.org/attachment.cgi?id=131576&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
Please consider to keep using "run/s" since it's stable.
I tried ms. But making them resulted unexpected (and typically longer) running
time, especially we cannot assume underlying environment.

Also, I guess |runStyle| could be specified externally via URL query string. 
Please do it if possible. Since this Dromaeo source is copied from upstream. If
there is any obvious errors there, 
I encourage you to upstream the fix.


More information about the webkit-reviews mailing list