[webkit-reviews] review granted: [Bug 80872] Web Inspector: Changes to the list of scripts for front-end compilation should not require update of number of scripts in module. : [Attachment 131393] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 80872: Web Inspector: Changes to the list of scripts for front-end
compilation should not require update of number of scripts in module.
https://bugs.webkit.org/show_bug.cgi?id=80872

Attachment 131393: Patch
https://bugs.webkit.org/attachment.cgi?id=131393&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131393&action=review


> Source/WebCore/inspector/compile-front-end.py:2
> +# Copyright (c) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/compile-front-end.py:47
> +	   "scripts": [

I would re-use gyp syntax here (target_name, sources, dependencies) so that we
could eventually migrate to gyp modules.