[webkit-reviews] review denied: [Bug 80719] Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths : [Attachment 131549] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 12 23:18:39 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 80719: Allow WebFileChooser to return extra file info (like displayName) in
addition to mere file paths
https://bugs.webkit.org/show_bug.cgi?id=80719
Attachment 131549: Patch
https://bugs.webkit.org/attachment.cgi?id=131549&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131549&action=review
> Source/WebCore/html/FileInputType.cpp:110
> + result.append("\xFF\xFE");
This is interpreted as ISO-8859-1, and U+00FF and U+00FE are valid characters.
I recommend to use U+FFFF.
String::fromUTF8("\xEF\xBF\xBF")
More information about the webkit-reviews
mailing list