[webkit-reviews] review granted: [Bug 80574] [Forms] Re-factor label.for tests for extending test coverage : [Attachment 131545] Patch 4

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 80574: [Forms] Re-factor label.for tests for extending test coverage
https://bugs.webkit.org/show_bug.cgi?id=80574

Attachment 131545: Patch 4
https://bugs.webkit.org/attachment.cgi?id=131545&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131545&action=review


>>>> LayoutTests/fast/forms/label/labels-add-htmlFor-label-expected.txt:53
>>>> +PASS element.labels.length is 1
>>> 
>>> Should they be FAIL?
>> 
>> No at this time.
>> 
>> Bug 80403 will fix "hidden" type and update test results.
> 
> When we fix Bug 80403, these tests will become FAIL.	So these tests are
incorrect at this moment.
> 
> We should write these tests so that they become PASS when Bug 80403 is fixed.


We discussed offline.  When Bug 80403 is fixed, These tests for hiddenType will
be dropped because of a check in getLabelableElementData.  So my comments made
no sense.