[webkit-reviews] review denied: [Bug 80719] Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths : [Attachment 131507] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 80719: Allow WebFileChooser to return extra file info (like displayName) in
addition to mere file paths
https://bugs.webkit.org/show_bug.cgi?id=80719

Attachment 131507: Patch
https://bugs.webkit.org/attachment.cgi?id=131507&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131507&action=review


> Source/WebCore/html/FileInputType.cpp:127
> +    Vector<FileChooserFileInfo> files;
> +    Vector<String> pathAndNames;
> +    state.split('\0', pathAndNames);
> +    for (unsigned i = 0; i < pathAndNames.size();) {
> +	   ASSERT(i + 1 < pathAndNames.size());
> +	   String path = pathAndNames[i++];
> +	   String name = pathAndNames[i++];
> +	   files.append(FileChooserFileInfo(path, name));
> +    }

We can't do this.
It's possible that a form control state saved by a browser without this patch,
and it is restored by a browser with this patch.

> Source/WebKit/chromium/src/WebFileChooserCompletionImpl.cpp:51
> +    for (unsigned i = 0; i < fileNames.size(); ++i) {
> +	 SelectedFileInfo file;
> +	 file.path = fileNames[i];
> +	 files.append(file);

Wrong indentation.