[webkit-reviews] review denied: [Bug 80743] [chromium] Use CCOcclusionTracker for draw culling : [Attachment 131434] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied  review:
Bug 80743: [chromium] Use CCOcclusionTracker for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80743

Attachment 131434: Patch
https://bugs.webkit.org/attachment.cgi?id=131434&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131434&action=review


> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:416
> +    for (size_t i = quadList.size(); i > 0; --i)
> +	   drawQuad(quadList[i-1].get(), renderPass->surfaceDamageRect());

style nit: s/i-1/i - 1/

If you're going to remove the explicit reversing of the quad list, can you
document in CCRenderPass that the quad list is in reverse order? Or,
alternatively encapsulate that in CCRenderPass with quad list accessors that do
the reversing internally, so that it doesn't trip anybody else up?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:258
> +	   surfacePassMap.add(renderSurface, pass.get());

Is this setting up for a use-after-free? I think the OwnPtr might be destroyed
after this loop exits.