[webkit-reviews] review granted: [Bug 80931] flexbox's computePreferredLogicalWidth needs to take multiline into account : [Attachment 131498] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 80931: flexbox's computePreferredLogicalWidth needs to take multiline into
account
https://bugs.webkit.org/show_bug.cgi?id=80931

Attachment 131498: Patch
https://bugs.webkit.org/attachment.cgi?id=131498&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131498&action=review


cq- just to give you a chance to address the nits if you want to.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:192
> +		   if (!isMultiline())

Nit: here and below i'd prefer to invert the if statement.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:861
> +	   if (!isColumnFlow() && crossAxisLength().isAuto())

s/crossAxisLength/logicalHeight ? Not sure if that's better or worse.