[webkit-reviews] review granted: [Bug 34679] Location and other objects are dysfunctional after a document gets restored from b/f cache : [Attachment 131489] Patch v1 - Fix + layout test

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 34679: Location and other objects are dysfunctional after a document gets
restored from b/f cache
https://bugs.webkit.org/show_bug.cgi?id=34679

Attachment 131489: Patch v1 - Fix + layout test 
https://bugs.webkit.org/attachment.cgi?id=131489&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131489&action=review


This looks great.

> Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp:63
> -    m_idbFactory = 0;
> +    m_suspendedIDBFactory = m_idbFactory.release();

That's a nice approach.

> Source/WebCore/page/DOMWindow.cpp:537
> +#if ENABLE(NOTIFICATIONS)
> +    // FIXME: Notifications shouldn't have different disconnection logic
than
> +    // the rest of the DOMWindowProperties.
> +    // There is currently no way to reconnect them in resumeFromPageCache()
so
> +    // they will be broken after returning to a cached page.
> +    resetNotifications();
> +#endif

This special case will be removed in
https://bugs.webkit.org/show_bug.cgi?id=79636