[webkit-reviews] review granted: [Bug 80906] _runtime_feature_list isn't supported on Apple Mac DRT : [Attachment 131445] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 80906: _runtime_feature_list isn't supported on Apple Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=80906

Attachment 131445: Patch
https://bugs.webkit.org/attachment.cgi?id=131445&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131445&action=review


Thanks for fixing this!

> Tools/Scripts/webkitpy/layout_tests/port/apple.py:99
> +	   # FIXME: Implement this properly?

I think that it's worth commenting that (a) it crashes because the script
doesn't set DYLD_FRAMEWORK_PATH, and (b) this feature may be obsolete now.