[webkit-reviews] review denied: [Bug 79068] SVG should support transform-origin and relative values : [Attachment 131435] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 79068: SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Attachment 131435: Patch
https://bugs.webkit.org/attachment.cgi?id=131435&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131435&action=review


Just snippets. But you don't have commuter rights yet.

> Source/WebCore/platform/Length.h:203
>	   return 0;

copyright is missing

> Source/WebCore/rendering/style/RenderStyle.cpp:4
> + * Copyright (C) 2011 Adobe Systems Incorporated. All Rights Reserved.

s/All Rights Reserved./All rights reserved./

> Source/WebCore/svg/SVGStyledTransformableElement.cpp:71
> +	   // Note: objectBoundingBox is an emptyRect for elements like pattern
or clipPath.

You should also reference to the spec text that demands that. Otherwise this
would not be a good enough reason to take a note instead of a fix me :)