[webkit-reviews] review granted: [Bug 80903] Web Inspector: InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly : [Attachment 131437] Make it use the StorageArea directly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 12 16:15:44 PDT 2012
Timothy Hatcher <timothy at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 80903: Web Inspector: InspectorDOMStorageAgent creates a Storage object
which is a DOMWindowProperty - Should use the StorageArea directly
https://bugs.webkit.org/show_bug.cgi?id=80903
Attachment 131437: Make it use the StorageArea directly
https://bugs.webkit.org/attachment.cgi?id=131437&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131437&action=review
> Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:115
> + Frame* frame = storageResource->frame();
> if (storageResource) {
These lines need flipped so the Frame is inside the null check. Fix before
landing.
More information about the webkit-reviews
mailing list