[webkit-reviews] review denied: [Bug 79068] SVG should support transform-origin and relative values : [Attachment 131360] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 79068: SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Attachment 131360: Patch
https://bugs.webkit.org/attachment.cgi?id=131360&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131360&action=review


Patch looks great. My suggestion about using the repaint.js harnes was wrong,
please use reftests for this, as we discussed in private mails.

> Source/WebCore/rendering/style/RenderStyle.h:897
> +    void applyTransform(TransformationMatrix&, const FloatRect& boundingBox,
ApplyTransformOrigin = IncludeTransformOrigin) const;

I would have still named it applyTransformForHTML vs. applyTransformForSVG.