[webkit-reviews] review granted: [Bug 80073] WebKit2: remove the last NSPasteboard access from the WebProcess : [Attachment 131370] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 80073: WebKit2: remove the last NSPasteboard access from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Attachment 131370: Patch
https://bugs.webkit.org/attachment.cgi?id=131370&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131370&action=review


> Source/WebCore/ChangeLog:3
> +	   WebKit2: remove the last NSPasteboard access from the WebProcess

Is the patch title still correct? We are again getting file paths in
WebProcess.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2691
> +	   NSData *data = [_data->_promisedImage->data()->createNSData()
autorelease];

This should use RetainPtr, not autorelease.