[webkit-reviews] review granted: [Bug 80673] Type conversion of exponential part failed : [Attachment 131194] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 12 12:22:19 PDT 2012
Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 80673: Type conversion of exponential part failed
https://bugs.webkit.org/show_bug.cgi?id=80673
Attachment 131194: Patch
https://bugs.webkit.org/attachment.cgi?id=131194&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131194&action=review
r=me
> Source/JavaScriptCore/wtf/dtoa/double-conversion.cc:437
> // Returns true if a nonspace found and false if the end has reached.
Please update this comment before committing -- and possibly the function name.
"Whitespace" would be a better term than "space".
More information about the webkit-reviews
mailing list