[webkit-reviews] review denied: [Bug 80615] CopiedSpace::tryAllocateOversize assumes system page size : [Attachment 131073] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Myles C. Maxfield
<mmaxfield at google.com>'s request for review:
Bug 80615: CopiedSpace::tryAllocateOversize assumes system page size
https://bugs.webkit.org/show_bug.cgi?id=80615

Attachment 131073: Patch
https://bugs.webkit.org/attachment.cgi?id=131073&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131073&action=review


r- based on Mark's comments.

> Source/JavaScriptCore/heap/CopiedSpaceInlineMethods.h:174
> +    size_t pageMask = ~(WTF::pageSize() - 1);

I'd prefer to see a WTF::pageMask() function, rather than one-off code in lots
of places.